[ISSUE #17] Corrected the angle functions to fix the incorrected results strans function according to the documentation. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dura0ok
changed the title
dura0ok
changed the title
esabol
approved these changes
Jul 21, 2023
vitcpp
approved these changes
Jul 23, 2023
|
I propose to change version to 1.2.3 (increment patch number) before merge. @stepan-neretin7 Could you please change the version number to 1.2.3 in the following places:
|
dura0ok
force-pushed
the
17_fix_theta_function
branch
2 times, most recently
from
714c473 to
ca147ef
Compare
esabol
suggested changes
Jul 23, 2023
dura0ok
force-pushed
the
17_fix_theta_function
branch
from
ca147ef to
ba50fcb
Compare
|
@stepan-neretin7 Thank you for the fix! It works on my side. I think the patch is ready for merge. The decision to increment version number was made because the fix is important. I propose to define version 1.2.3 as stable and assign the tag '1.2.3'. Stub upgrade script was added to make upgrade process to complete without errors. |
esabol
approved these changes
Jul 24, 2023
|
Looks good to me! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that our corners are float8, and for some reason pointers were returned.